fix(OverflowMenu): avoid trapping focus on trigger button #4688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
emyarod
force-pushed
the
4659-overflowmenu-focus-trap
branch
from
8b11d01
to
6d53455
Compare
|
Deploy preview for the-carbon-components ready! Built with commit 615012a https://deploy-preview-4688--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 615012a |
|
Deploy preview for carbon-components-react ready! Built with commit 615012a https://deploy-preview-4688--carbon-components-react.netlify.com |
joshblack
approved these changes
Nov 15, 2019
vpicone
approved these changes
Nov 18, 2019
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4659
This PR prevents the overflow menu trigger button from trapping focus
Changelog
Changed
Testing / Reviewing
Navigate to the overflow menu trigger button with the keyboard. You should be able to navigate away with Tab now