fix: dynamic classes only now functional (#4780)

carbon-design-system · Nov 28, 2019 · c170f74 · c170f74
1 parent 9d51071
commit c170f74
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/packages/icons-vue/tasks/__tests__/createIconComponent-test.js b/packages/icons-vue/tasks/__tests__/createIconComponent-test.js
@@ -195,6 +195,23 @@ describe('createIconComponent', () => {
     expect(node.classList.contains(dynamicClass)).toBe(true);
   });
 
+  it('should support dynamic classes only', async () => {
+    const dynamicClass = 'bar';
+    const node = render({
+      components: {
+        [MockIconComponent.name]: MockIconComponent,
+      },
+      data() {
+        return {
+          myDynamicClass: dynamicClass,
+        };
+      },
+      template: `<MockIcon v-bind:class="myDynamicClass" />`,
+    });
+
+    expect(node.classList.contains(dynamicClass)).toBe(true);
+  });
+
   it('should be focusable if aria-label and tabindex is used', async () => {
     const label = 'custom-label';
     const node = render({

diff --git a/packages/icons-vue/tasks/createIconComponent.js b/packages/icons-vue/tasks/createIconComponent.js
@@ -55,6 +55,7 @@ export default {
       };
     }
     if (data.class) {
+      svgData.class = svgData.class || {}; // may be no static class
       svgData.class[data.class] = true;
     }
     return createElement('svg', svgData, [