fix: dynamic classes only now functional #4780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for the-carbon-components ready! Built with commit d2f8d43 https://deploy-preview-4780--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit d2f8d43 |
|
Deploy preview for carbon-components-react ready! Built with commit d2f8d43 https://deploy-preview-4780--carbon-components-react.netlify.com |
asudoh
approved these changes
Nov 27, 2019
emyarod
approved these changes
Nov 27, 2019
| @@ -55,6 +55,7 @@ export default { | |||
| }; | |||
| } | |||
| if (data.class) { | |||
| svgData.class = svgData.class || {}; // may be no static class | |||
There was a problem hiding this comment.
just wondering could the default value for svgData.class be an empty object as well? on L48:
const svgData = {
attrs,
on: listeners,
class: {},
};There was a problem hiding this comment.
I don't think it will do any harm, I was just trying to make the minimal impact change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4779
Add the ability to use dynamic classes only in @carbon/icons-vue
Changelog
m packages/icons-vue/tasks/tests/createIconComponent-test.js
m packages/icons-vue/tasks/createIconComponent.js
Testing / Reviewing
Without this I am unable to progress the use of carbon prefix for classes in some @carbon/vue components.