Skip to content

Commit

Permalink
fix(a11y): dap errors with MultiSelect.Filterable (#6906)
Browse files Browse the repository at this point in the history
* fix(a11y): dap errors with MultiSelect.Filterable

* chore(snapshot): update snapshots

Co-authored-by: Ricardo Henriquez <Ricardo@Ricardos-MBP.lan>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
  • Loading branch information
3 people committed Sep 25, 2020
1 parent 583b137 commit eb3dcf0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -398,9 +398,9 @@ export default class FilterableMultiSelect extends React.Component {
aria-controls={`${id}__menu`}
aria-autocomplete="list"
ref={(el) => (this.inputNode = el)}
id={`${id}-input`}
{...getInputProps({
disabled,
id,
placeholder,
onKeyDown: this.handleOnInputKeyDown,
})}
Expand All @@ -423,7 +423,7 @@ export default class FilterableMultiSelect extends React.Component {
</ListBox.Field>
{isOpen && (
<ListBox.Menu
role="group"
role="listbox"
aria-label={ariaLabel}
id={`${id}-menu`}>
{sortItems(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ exports[`MultiSelect.Filterable should render 1`] = `
autoComplete="off"
className="bx--text-input bx--text-input--empty"
disabled={false}
id="test-filterable-multiselect"
id="test-filterable-multiselect-input"
onBlur={[Function]}
onChange={[Function]}
onKeyDown={[Function]}
Expand Down

0 comments on commit eb3dcf0

Please sign in to comment.