Skip to content

Commit

Permalink
fix(composed-modal): moves aria-label from close icon to close button (
Browse files Browse the repository at this point in the history
  • Loading branch information
abbeyhrt authored and asudoh committed Nov 19, 2019
1 parent 6c0aaba commit fd1b01d
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions packages/react/src/components/ComposedModal/ComposedModal.js
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ export class ModalHeader extends Component {
};

static defaultProps = {
iconDescription: 'Close the modal',
iconDescription: 'Close',
buttonOnClick: () => {},
};

Expand Down Expand Up @@ -373,8 +373,9 @@ export class ModalHeader extends Component {
onClick={this.handleCloseButtonClick}
className={closeClass}
title={iconDescription}
aria-label={iconDescription}
type="button">
<Close20 aria-label={iconDescription} className={closeIconClass} />
<Close20 className={closeIconClass} />
</button>
</div>
);
Expand Down

0 comments on commit fd1b01d

Please sign in to comment.