fix(composed-modal): moves aria-label from close icon to close button #4727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for the-carbon-components ready! Built with commit b5f3820 https://deploy-preview-4727--the-carbon-components.netlify.com |
|
Deploy preview for carbon-components-react ready! Built with commit b5f3820 https://deploy-preview-4727--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit b5f3820 |
joshblack
approved these changes
Nov 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4707
This PR moves the
aria-labelthat was on theClose20icon to the closebuttonremoving this DAP violation. Also changes the default value oficonDescriptionto just 'Close'.Changelog
Changed
aria-labelTesting / Reviewing
Run DAP on the ComposedModal and make sure you do not see the above violation.