Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to understand the why validation error message looks different for number input compared to other input elements #1051

Closed
subinpc opened this issue Aug 29, 2018 · 4 comments
Closed

Need to understand the why validation error message looks different for number input compared to other input elements #1051

subinpc opened this issue Aug 29, 2018 · 4 comments

Comments

@subinpc
Copy link

subinpc commented Aug 29, 2018 •
edited

Detailed description

I would like to understand why the style for number-input validation error is different from the style for other form field validation errors?
image 5

Is this issue related to a specific component?

form input components

Add labels

discussion
@asudoh
Copy link
Contributor

asudoh commented Aug 29, 2018 •
edited

@subinpc Thank you for reporting - For better manager the issues, could you please split those two…? Thanks!

@subinpc subinpc changed the title Need to understand the way certains form elements behave in carbon v9 Need to understand the why validation error message looks different for number input compared to other input elements Aug 29, 2018
@subinpc
Copy link
Author

subinpc commented Aug 29, 2018

@asudoh, I've moved my second question to a separate issue - #1052.

@alisonjoseph
Copy link
Member

Hi, thanks for pointing this out. Looks like bug, they should look the same and not have the extra red line below.

asudoh added a commit to asudoh/carbon-components that referenced this issue Sep 3, 2018
@asudoh
fix(form): make the form validation style of list box more specific
b518fd6 
Fixes carbon-design-system#1051.
@asudoh asudoh mentioned this issue Sep 3, 2018
Merged
asudoh added a commit to asudoh/carbon-components that referenced this issue Sep 3, 2018
@asudoh
fix(form): make the form validation style of list box more specific
5101a16 
Fixes carbon-design-system#1051.
alisonjoseph pushed a commit that referenced this issue Sep 4, 2018
@asudoh @alisonjoseph
fix(form): make the form validation style of list box more specific (#…
aff7b2b 
…1059)

Fixes #1051.
@carbon-bot
Copy link
Contributor

🎉 This issue has been resolved in version 9.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

joshblack pushed a commit to joshblack/carbon that referenced this issue May 2, 2019
@jaredcaraway @marijohannessen
Fix typo in selected example tabs component (carbon-design-system#1051)
a4946fd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@asudoh @alisonjoseph @subinpc @carbon-bot