Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Warning icon in TextArea #10910

Closed
3 tasks done
Addeuz opened this issue Mar 4, 2022 · 3 comments · Fixed by #13293
Closed
3 tasks done

[Feature Request]: Warning icon in TextArea #10910

Addeuz opened this issue Mar 4, 2022 · 3 comments · Fixed by #13293
Labels
component: text-area planning: umbrella Umbrella issues, surfaced in Projects views proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: design ✏️ role: dev 🤖 type: enhancement 💡
Milestone

Comments

@Addeuz
Copy link

Addeuz commented Mar 4, 2022

Summary

I would really like the TextArea component to have a warning option similar to the warn and warnText prop on TextInput.

Justification

We use TextAreas quite a lot in our system at work but feel like the invalid prop sometimes is too "aggressive". And sometimes the text is not invalid but should give a warning.

Desired UX and success metrics

Same ux and metrics for the warn and warnText props on TextInput basically.

Required functionality

See desired UX and success metrics.

Specific timeline issues / requests

ASAP as we plan to release a beta for a reference group late march.

Available extra resources

No response

Code of Conduct

#10910 (comment)

@joshblack
Copy link
Contributor

Hi there @Addeuz! 👋 Thanks for taking the time to put this proposal together 🙏

On our end, I've added this issue to our proposal backlog. This backlog gets triaged every other week and is where we talk about feature requests and decide the next best action on them.

Let me know if you have any additional questions about this process! I'd love to help out.

@jnm2377
Copy link
Contributor

jnm2377 commented Mar 21, 2022

Hi @Addeuz thanks for bringing this up. We will work on adding this for TextArea! Right now, we are still finishing v11, so we won't work on it immediately, but if you're in need of it soon, we would accept a contribution. :)

@jnm2377 jnm2377 added role: dev 🤖 proposal: accepted This request has gone through triaging and we are accepting PR's against it. and removed proposal: open This request has gone through triaging. We're determining whether we take this on or not. labels Mar 21, 2022
@sstrubberg sstrubberg added the needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. label Oct 11, 2022
@sstrubberg sstrubberg removed the needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. label Dec 15, 2022
@sstrubberg sstrubberg added this to the 2023 Q1 milestone Dec 15, 2022
@aagonzales
Copy link
Member

aagonzales commented Feb 28, 2023

Final spec

Figma file

Default

image

Fluid

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: text-area planning: umbrella Umbrella issues, surfaced in Projects views proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: design ✏️ role: dev 🤖 type: enhancement 💡
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

7 participants