Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure changes made to @carbon/react are SSR compatible with eslint-plugin-ssr-friendly #14283

Closed
2 tasks
Tracked by #13623
tay1orjones opened this issue Jul 21, 2023 · 0 comments · Fixed by #15903
Closed
2 tasks
Tracked by #13623

Ensure changes made to @carbon/react are SSR compatible with eslint-plugin-ssr-friendly #14283

tay1orjones opened this issue Jul 21, 2023 · 0 comments · Fixed by #15903
Assignees
@alisonjoseph
Labels
package: @carbon/react @carbon/react proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: dev 🤖 type: enhancement 💡
Milestone
2024 Q1

Comments

@tay1orjones
Copy link
Member

tay1orjones commented Jul 21, 2023 •
edited by alisonjoseph

We have pieces of infrastructure in place to help ensure that components are SSR compatible, for example the useIsomorphicEffect() internal helper hook, but we could improve this further by using static analysis to catch potential issues before they get merged.

Tasks
Beta Give feedback
@tay1orjones tay1orjones mentioned this issue Jul 21, 2023
Open
@sstrubberg sstrubberg added package: @carbon/react @carbon/react proposal: open This request has gone through triaging. We're determining whether we take this on or not. labels Aug 9, 2023
@sstrubberg sstrubberg added proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: dev 🤖 and removed proposal: open This request has gone through triaging. We're determining whether we take this on or not. labels Nov 7, 2023
@sstrubberg sstrubberg added this to the 2023 Q4 milestone Nov 7, 2023
@sstrubberg sstrubberg modified the milestones: 2023 Q4, 2024 Q1 Jan 9, 2024
@alisonjoseph alisonjoseph mentioned this issue Mar 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alisonjoseph alisonjoseph

Labels
package: @carbon/react @carbon/react proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: dev 🤖 type: enhancement 💡
Projects
Design System
Status: ✅ Done
Enhancements Roadmap
Archived in project
Milestone
2024 Q1
Development

Successfully merging a pull request may close this issue.

feat: add eslint-plugin-ssr-friendly alisonjoseph/carbon
3 participants
@alisonjoseph @tay1orjones @sstrubberg