New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add eslint-plugin-ssr-friendly #15903
feat: add eslint-plugin-ssr-friendly #15903
Conversation
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I think a lot of the errors could be resolved by putting the various calls to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one suggestion
325a5b0
Hey there! v11.54.0 was just released that references this issue/PR. |
* feat: add eslint-plugin-ssr-friendly * fix: eslint ssr-friendly errors * chore: ignore test and story files * chore: remove ignore line from story and test files * fix: undo menu changes and add comment
Closes #14283
Changelog
New
eslint-plugin-ssr-friendly
Changed
Testing / Reviewing
Make sure Menu and SliderSkeleton still behave as expected.