Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User cannot access month selector buttons or year selector form in Date Picker Range Component #1471

Closed
dakahn opened this issue Nov 25, 2018 · 11 comments
Labels
status: inactive Will close if there's no further activity within a given time type: a11y ♿

Comments

@dakahn
Copy link
Contributor

dakahn commented Nov 25, 2018

Environment

Chrome 70
macOS Mojave

Violation

When the user activates the calendar drop down in the date picker component they cannot either

  1. user the arrow key down to select the left and right chevron to change the months and the year picker or
  2. tab down to the left and right chevrons and year picker in a logical order.
@dakahn dakahn changed the title User cannot access month selector buttons or year selector form in Date Picker Component User cannot access month selector buttons or year selector form in Date Picker Range Component Jan 21, 2019
@SimonFinney
Copy link
Contributor

What is the status of this issue?

@dakahn
Copy link
Contributor Author

dakahn commented Jan 29, 2019

Issue is in our backlog and should be addressed this sprint. Feel free to submit a PR though! 👍

@dakahn
Copy link
Contributor Author

dakahn commented Feb 19, 2019

When I was doing some accessibility testing about a month ago I opened this issue. As you can see the lack of keyboard navigation support is a known issue with the library we're using to display our calendar dropdown. I've spent the morning looking for a solution on our end, but it seems like we're stuck as long as we're using Flatpickr

Changing our Datepicker to use a native html5 date input seems to be how to move forward. This is a larger -- and breaking change and will take more time.

@tw15egan
Copy link
Member

Have we opened an issue over on Flatpickr?

@dakahn
Copy link
Contributor Author

dakahn commented Feb 19, 2019

I opened an issue a month ago (linked above). Worth noting as well is that Flatpickr development has slowed.

@dakahn
Copy link
Contributor Author

dakahn commented Feb 19, 2019

I opened a ticket to cover the breaking changes proposed (in our React repo, since that's where I'm more comfortable working). I'm digging into this now and you can follow progress there..

@stale
Copy link

stale bot commented May 1, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. Thanks for your contributions.

@stale stale bot added the wontfix label May 1, 2019
@dakahn
Copy link
Contributor Author

dakahn commented May 2, 2019

Leaving this issue open since these problems still exist. Datepicker is a refactor candidate for sure. Since we're moving forward with Flatpickr we need to find someway to allow the left and right arrows (changing the months) to be keyboard accessible. Doable, but would take some investigation.

@stale stale bot removed the wontfix label May 2, 2019
@stale
Copy link

stale bot commented May 16, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the status: inactive Will close if there's no further activity within a given time label May 16, 2019
@stale
Copy link

stale bot commented May 19, 2019

As there's been no activity since this issue was marked as stale, we are auto-closing it.

@stale stale bot closed this as completed May 19, 2019
@asudoh
Copy link
Contributor

asudoh commented Sep 13, 2019

#3655 fixes the problem; Once you focus on date picker with down arrow key, you can use ctrl-left/right to go to previous/next month, ctrl-up/down to go to previous/next year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: inactive Will close if there's no further activity within a given time type: a11y ♿
Projects
None yet
Development

No branches or pull requests

4 participants