Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: DataTableHeader now has a required prop called slug #15737

Closed
2 tasks done
ggdawson opened this issue Feb 12, 2024 · 0 comments · Fixed by #15738
Closed
2 tasks done

[Bug]: DataTableHeader now has a required prop called slug #15737

ggdawson opened this issue Feb 12, 2024 · 0 comments · Fixed by #15738

Comments

@ggdawson
Copy link
Contributor

Package

@carbon/react

Browser

No response

Package version

v1.50.0

React version

v17.0.2

Description

The headers prop for DataTable now seems to require a slug property in TS projects. Following the types, it seems like DataTableHeader simply needs to have this marked as optional.

Reproduction/example

https://stackblitz.com/edit/stackblitz-starters-267fuz?file=src%2FApp.tsx

Steps to reproduce

Try using the DataTable component in a TypeScript project. If you pass a headers prop, and those headers do not have a slug property, then the component will not type-check.

Suggested Severity

Severity 3 = User can complete task, and/or has a workaround within the user experience of a given component.

Application/PAL

Randori

Code of Conduct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant