Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DataTable): make DataTableHeader.slug optional #15738

Merged
merged 1 commit into from Feb 12, 2024

Conversation

ggdawson
Copy link
Contributor

@ggdawson ggdawson commented Feb 12, 2024

Closes #15737

Makes the slug property of DataTableHeader optional.

Changelog

New

  • n/a

Changed

  • DataTableHeader type

Removed

  • n/a

Testing / Reviewing

repro

To test, use the updated type.

@ggdawson ggdawson requested a review from a team as a code owner February 12, 2024 18:06
@ggdawson
Copy link
Contributor Author

#15737

Copy link

netlify bot commented Feb 12, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7ef8ddf
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/65ca5e41981da20008f94d61
😎 Deploy Preview https://deploy-preview-15738--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@ggdawson
Copy link
Contributor Author

Hey @tw15egan, I'm not familiar with the percy check, or why it's failing. Is there documentation around on that check?

@tw15egan
Copy link
Member

@ggdawson no worries, Ill fix it

@carbon-bot carbon-bot added this pull request to the merge queue Feb 12, 2024
Merged via the queue into carbon-design-system:main with commit 2529006 Feb 12, 2024
22 checks passed
@ggdawson ggdawson deleted the data-table-slug branch February 12, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: DataTableHeader now has a required prop called slug
4 participants