Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Audit] Tooltip #1954

Closed
8 of 11 tasks
joshblack opened this issue Feb 28, 2019 · 2 comments
Closed
8 of 11 tasks

[Audit] Tooltip #1954

joshblack opened this issue Feb 28, 2019 · 2 comments
Assignees
Labels
role: dev 🤖 type: bug 🐛 version: 10 Issues pertaining to Carbon v10
Milestone

Comments

@joshblack
Copy link
Contributor

joshblack commented Feb 28, 2019

Interactive Tooltip

  • Button should not have vertical padding

Expected:

screen shot 2019-02-28 at 10 23 39 am

Actual:

screen shot 2019-02-28 at 10 23 42 am

  • Label should be label-01, #565656

  • Icon should use #565656, what's the token @jeanservaas?

  • What should the vertical distance be between the tooltip box and the icon? Seems like it's 13px in the spec but 16px in the implementation cc @jeanservaas

  • Test needs to use body-long-01

Icon Tooltip

  • Direction of tooltip seems flipped, should go down but is going up
  • Height should be 24px, right now it's 32px
  • Text should use body-short-01 token

Definition Tooltip

  • Tooltip background should not have right padding

Expected:

screen shot 2019-02-28 at 10 30 33 am

Actual:

screen shot 2019-02-28 at 10 30 37 am

  • Tooltip text should be centered

  • What type style should this use @jeanservaas? body-short-01? In spec it's IBM Type C

@jeanservaas
Copy link
Contributor

@joshblack

  • Icon token for (#565656) should be $icon-02

Also, I reuploaded the spec, but I noticed another discrepancy in the spec and the changelog i think,

  • definition tooltip and interactive tooltip should be calling $label-01 ( you can see all type tokens spec'd in the file now... everything inside the tooltip is $body-short-01 any type outside the tooltip... we're going to go with $label-01 right now, even for the definition tooltip. Sorry for the confusion!

image

image

  • Also, is this the distance you were asking about?

image

@carbon-bot
Copy link
Contributor

🎉 This issue has been resolved in version 9.83.19 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: dev 🤖 type: bug 🐛 version: 10 Issues pertaining to Carbon v10
Projects
None yet
Development

No branches or pull requests

4 participants