Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carbon Style: Sass is taking too long to compile #3348

Closed
abhisheksinghrana opened this issue Jul 11, 2019 · 7 comments
Closed

Carbon Style: Sass is taking too long to compile #3348

abhisheksinghrana opened this issue Jul 11, 2019 · 7 comments
Labels
status: inactive Will close if there's no further activity within a given time type: enhancement 💡

Comments

@abhisheksinghrana
Copy link

abhisheksinghrana commented Jul 11, 2019

Currently, I am using carbon component style sass.
When i include them inside my styles scss. It increasing the build time rapidly.

For eg. If I add only component data-table.scss in my common sass, it increases build time by about 2 seconds.

So, Without styles.scss, Live reload build time is around 1.8 seconds and after including styles.scss it is around 40 seconds.

"carbon-components": "^10.3.1"

@project-bot project-bot bot added this to Issue: needs triage 💊 in Carbon support Jul 11, 2019
@abhisheksinghrana abhisheksinghrana changed the title Data Table: Add table level sort config Carbon Style: Sass is taking too long to compile Jul 11, 2019
@asudoh
Copy link
Contributor

asudoh commented Jul 11, 2019

Hi 👋 this kind of issues tend to have many factors in play, so great to see you articulate your environment. One known issue is with custom Sass importer (and thus WebPack), written in issue# 857 in https://github.com/sass/node-sass, and issue# 296 in https://github.com/webpack-contrib/sass-loader.

@stale
Copy link

stale bot commented Aug 10, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the status: inactive Will close if there's no further activity within a given time label Aug 10, 2019
@stale
Copy link

stale bot commented Aug 13, 2019

As there's been no activity since this issue was marked as stale, we are auto-closing it.

@stale stale bot closed this as completed Aug 13, 2019
Carbon support automation moved this from Issue: needs triage 💊 to Issue/PR: Closed 🙌 Aug 13, 2019
@R4VANG3R
Copy link

R4VANG3R commented Nov 1, 2019

Any update on this? I'm also seeing build times of 40s+ with a basically clean storybook project

@bitforcesrl
Copy link

I am also experiencing a very long time (about 1 minute) when compiling
~carbon-components/scss/globals/scss/styles

I created a custom scss import in order not to import all the components scss, and I manage to save some seconds per component. Still it doesn't seem a good solution, just a patch.

I also installed fibers to speed up the process, but it didn't change much.

Any update?

@baeharam
Copy link
Contributor

baeharam commented Jun 4, 2020

This is very serious problem... I don't know it is the problem of Carbon or sass-loader, but must be improved

@bitforcesrl
Copy link

The problem is still there and i slowing down a lot our development process.
We've updated Angular to 9.1 and the carbon lib too. But it is still very slow!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: inactive Will close if there's no further activity within a given time type: enhancement 💡
Projects
None yet
Development

No branches or pull requests

5 participants