-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modals - function mismatch #6000
Comments
Hi @marceltrautmann thanks for opening this issue. You bring up a good point. The functionality you see in our docs is coming directly from our Carbon package since |
Note for devs: the component demo is using |
As of today, our click-outside logic works regardless of passive/transactional mode. CC @carbon-design-system/design to see if it should be changed. Another note is that |
I'm not sure how a |
It looks like the |
Thank you for clarifying @aagonzales! Wrt where |
@alisonjoseph Can we pls cue this up for the next sprint planning? This is a priority issue for the Watson Assistant team. Thanks! |
https://www.carbondesignsystem.com/components/modal/code
The example given is a transactional modal (evident by the two buttons), yet – per the guidance on the usage page – transaction modals should not be dismissable by clicking outside the modal. In the example given it is dismissable just like a passive modal.
Given this is a reference used by many I suggest making the example follow the same guidance to help avoid the same confusion my team just did.
The text was updated successfully, but these errors were encountered: