Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InlineLoading inactive state animation is broken #9163

Closed
2 tasks done
Tracked by #9123
yasotnik opened this issue Jul 12, 2021 · 4 comments · Fixed by #9209
Closed
2 tasks done
Tracked by #9123

InlineLoading inactive state animation is broken #9163

yasotnik opened this issue Jul 12, 2021 · 4 comments · Fixed by #9209

Comments

@yasotnik
Copy link

yasotnik commented Jul 12, 2021

Brief description

InlineLoading component inactive state animation is broken:

image

What package(s) are you using?

  • carbon-components
  • carbon-components-react

Detailed description

Looks like inactive state in InlineLoading component has some weird animation of circle spinning backwards (?).
Versions used:
carbon-components@10.29.0
carbon-components-react@7.29.0

Tested both in Firefox (89.0.2 (64-bit)) and Chrome (Version 91.0.4472.124 (Official Build) (64-bit))

Steps to reproduce the issue

Have InlineComponent with status='inactive'.
You could reproduce it in react-components storybook e.g InlineComponent

Notes:

Looks like it was introduced with carbon-components-react 7.6.0

@yasotnik
Copy link
Author

yasotnik commented Jul 12, 2021

Looks like when it was working it had just spinning animation in inactive state.
Should not it be just a grey circle instead ? I am not a UX expert but from my perspective as a user it will be more natural.

Seems like it has the same behavior as active state from around 6.10.0
image
Link codesandbox

@emyarod
Copy link
Member

emyarod commented Jul 12, 2021

cc @carbon-design-system/design just to confirm, what should the inactive state inline loading indicator look like?

@yasotnik
Copy link
Author

I guess bot added wrong label to the issue.
@emyarod
I am not part of the carbon team but what I have found so far there should not be an INACTIVE state at all.
Link
The inactive loading state is when no data is being loaded. Inactive has no visual indicator.

@aagonzales
Copy link
Member

Yeah inactive just animates to no visual. I was working correctly in previous releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants