Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(loading): remove progress bar on inactive state #9209

Merged
merged 7 commits into from
Jul 29, 2021
Merged

fix(loading): remove progress bar on inactive state #9209

merged 7 commits into from
Jul 29, 2021

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Jul 15, 2021

Closes #9163

This PR updates the loading and inline loading inactive states to resolve a regression in appearance.

Changelog

New

  • progress percentage function to calculate loading/inline loading appearance

Changed

  • consolidate loading and inline loading styles further

Testing / Reviewing

Confirm the loading and inline loading spinners appear correct (small and default sizes, active and inactive states)

@emyarod emyarod requested a review from aagonzales July 15, 2021 21:32
@emyarod emyarod requested a review from a team as a code owner July 15, 2021 21:32
@emyarod emyarod requested review from tw15egan and jnm2377 July 15, 2021 21:32
@netlify
Copy link

netlify bot commented Jul 15, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: bf49b9d

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6102e5c61f627800076f6287

😎 Browse the preview: https://deploy-preview-9209--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Jul 15, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: bf49b9d

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6102e5c65254f300084d4215

😎 Browse the preview: https://deploy-preview-9209--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jul 15, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: bf49b9d

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6102e5c687a6a50007d0b640

😎 Browse the preview: https://deploy-preview-9209--carbon-components-react.netlify.app

aagonzales
aagonzales approved these changes Jul 19, 2021
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tw15egan
tw15egan approved these changes Jul 20, 2021
View reviewed changes
Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@tw15egan
Copy link
Member

@emyarod was just thinking, could you also port these styles to the @carbon/styles package? Looks like we've already got that component in and want to make sure we get it fixed there as well

@emyarod emyarod force-pushed the 9163-inlineloading-inactive-state branch from 5287839 to 244ed2d Compare July 20, 2021 15:26
@emyarod emyarod requested a review from tw15egan July 20, 2021 15:27
@emyarod
Copy link
Member Author

emyarod commented Jul 20, 2021

@tw15egan added them to @carbon/styles as well

@tw15egan
Copy link
Member

Looks great, thanks for adding that 🎉

tw15egan
tw15egan approved these changes Jul 22, 2021
View reviewed changes
Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@emyarod emyarod requested a review from a team July 22, 2021 16:53
@emyarod emyarod mentioned this pull request Jul 26, 2021
Closed
62 tasks
@kodiakhq kodiakhq bot merged commit b01e485 into carbon-design-system:main Jul 29, 2021
This was referenced Aug 3, 2021
Merged
Merged
@emyarod emyarod deleted the 9163-inlineloading-inactive-state branch August 30, 2021 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aagonzales aagonzales aagonzales approved these changes

@tw15egan tw15egan tw15egan approved these changes

@jnm2377 jnm2377 Awaiting requested review from jnm2377

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

InlineLoading inactive state animation is broken
4 participants
@emyarod @tw15egan @aagonzales @joshblack