-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v11 Prop Changes #9535
Closed
14 of 20 tasks
Labels
planning: umbrella
Umbrella issues, surfaced in Projects views
Comments
PatternsDeprecating a prop
handleClick: deprecate(
PropTypes.func,
'The handleClick prop for ClickableTile has been deprecated in favor of onClick. It will be removed in the next major release.'
), Scenarios
Deprecations
Feature flags
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This was referenced Sep 9, 2021
37 tasks
This was referenced Oct 20, 2021
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Goal
We want the props for the components in our React library to be consistent and predictable. Props should follow common or familiar conventions and should be consistent across components in the design system.
Links & Resources
Related issues
Checklist
handle*
toon*
handleClick
handleKeyDown
- Only exists inhandleOpen
ModalWrapper
- component no longer maintained.- Only exists inhandleOverflowMenuItemFocus
OverflowMenu
and is not consumable by the user.- Only exists inhandleSubmit
ModalWrapper
- component no longer maintained.- Is a child ofhandleTabClick
Tabs
and is not consumable by the user.- Is a child ofhandleTabKeyDown
Tabs
and is not consumable by the user.type
,kind
, andvariant
for v11 #9623iconDescription
for v11 #9624light
prop usage withLayer
component #9763evt.persist()
ariaLabel
toaria-label
: https://carbon-react-explorer.vercel.app/props/ariaLabelQuestions
defaultToggled
prop make sense? Can you have something be in a "toggled" state or should we indicate that as on/open instead?The text was updated successfully, but these errors were encountered: