Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ToggleSmall): remove outdated tests #12992

Merged
merged 1 commit into from Jan 19, 2023

Conversation

tw15egan
Copy link
Member

Closes #12681

ToggleSmall has been deprecated and can be used by passing size='sm' to the regular Toggle component. Since these tests are already covered in Toggle-test.js, I've gone ahead and removed this file.

Changelog

Removed

  • outdated tests in ToggleSmall

Testing / Reviewing

Ensure all tests pass and <Toggle size='sm' /> is being tested properly in Toggle-test.js

@tw15egan tw15egan requested a review from a team as a code owner January 19, 2023 17:31
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@netlify
Copy link

netlify bot commented Jan 19, 2023

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit 8cbdc58
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/63c97e6ab62fd50008890c89
😎 Deploy Preview https://deploy-preview-12992--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jan 19, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 8cbdc58
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/63c97e6ab4080f0008b2bf15
😎 Deploy Preview https://deploy-preview-12992--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 yay cleanup!

@kodiakhq kodiakhq bot merged commit 1a64eb7 into carbon-design-system:main Jan 19, 2023
@carbon-bot
Copy link
Contributor

Hey there! v11.21.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use RTL for testing in ToggleSmall/ToggleSmall-test.js
4 participants