docs(storybook): use storybook-addon-accessibility-checker #14926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tay1orjones
commented
Oct 24, 2023
tay1orjones
commented
Oct 24, 2023
I'm seeing these warnings also :/ |
|
Hey @tombrunet we're unfortunately seeing some issues with this. I'm not sure exactly what the culprit is 🤔 For me it was occuring after setting the theme in the theme switcher, navigating through some ComposedModal stories, and then setting some controls (that modify the params in the url). |
|
The latest rc of the addon fixes these issues, thanks @tombrunet! |
andreancardona
approved these changes
Nov 28, 2023
andreancardona
added
status: one more review 👀
and removed
status: ready for review 👀
labels
tay1orjones
added
status: ready to merge 🎉
and removed
status: one more review 👀
labels
…orybook-a11y-addon-ibma
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Merged
via the queue into
carbon-design-system:main
with commit Dec 19, 2023
f504b2e
20 checks passed
danoro96
pushed a commit
to danoro96/carbon
that referenced
this pull request
Jan 18, 2024
…sign-system#14926) * docs(storybook): use storybook-addon-accessibility-checker * chore: yarn dedupe * chore: update storybook-addon-accessibility-checker * chore: yarn dedupe * chore(yarn): run dedupe --------- Co-authored-by: Andrea N. Cardona <cardona.n.andrea@gmail.com> Co-authored-by: TJ Egan <tw15egan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IBM Accessibility team has been working on a modified/forked @storybook/addon-a11y that serves the same purpose but allows the engine to be configurable to use accessibility-checker instead of axe. This PR is for testing the addon.
Changelog
New
storybook-addon-accessibility-checkerinstead of@storybook/addon-a11yTesting / Reviewing