Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Modal Close button a11y issues #15057

Merged
merged 19 commits into from Jan 11, 2024
Merged

fix: Modal Close button a11y issues #15057

merged 19 commits into from Jan 11, 2024

Conversation

k-rajat19
Copy link
Contributor

@k-rajat19 k-rajat19 commented Oct 28, 2023 •
edited by tay1orjones

Closes #14988
Closes #14323
Closes #13232

  • Refactored Modal to use IconButton so that it uses correct tooltip
  • fixed the value of title

Testing / Reviewing

Tested component in storybook it's working as expected

@k-rajat19 k-rajat19 requested a review from a team as a code owner October 28, 2023 21:22
@netlify
Copy link

netlify bot commented Oct 28, 2023 •
edited

✅ Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit d33112d
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/659d70a41e1cd00008ca7ef7
😎 Deploy Preview https://deploy-preview-15057--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 28, 2023 •
edited

✅ Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 67324a7
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6543e549d15c3b00082a62da
😎 Deploy Preview https://deploy-preview-15057--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k-rajat19 k-rajat19 changed the title refactor: Modal Close button a11y issues fix: Modal Close button a11y issues Oct 29, 2023
tay1orjones
tay1orjones requested changes Oct 30, 2023
View reviewed changes
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this PR! Just a couple things to address below, let me know what you think.

packages/styles/scss/components/modal/_modal.scss Outdated Show resolved Hide resolved
packages/react/src/components/Modal/Modal.tsx Outdated Show resolved Hide resolved
packages/react/src/components/Modal/Modal.tsx Show resolved Hide resolved
@tay1orjones
Copy link
Member

I saw CI was getting a compiler error, so I went ahead and pushed an update here that includes new TypeScript types for IconButton

@jdharvey-ibm
Copy link
Member

@tay1orjones @tw15egan I pushed some updated type stuff here that'll hopefully resolve the issues, but I left some TODOs in the code that need expert input. LMK if you want to discuss any of them!

@Tresau Tresau mentioned this pull request Nov 15, 2023
Merged
@tay1orjones tay1orjones self-assigned this Nov 29, 2023
@tay1orjones tay1orjones added this to the 2023 Q4 milestone Nov 29, 2023
This was referenced Dec 15, 2023
Merged
Closed
@mattborghi mattborghi mentioned this pull request Dec 17, 2023
Closed
@tay1orjones tay1orjones modified the milestones: 2023 Q4, 2024 Q1 Jan 3, 2024
@k-rajat19 k-rajat19 requested a review from a team as a code owner January 4, 2024 20:43
@tw15egan
Copy link
Member

tw15egan commented Jan 9, 2024

@tay1orjones I just pushed up some changes that should fix the Percy issues. Could you take another look before we (finally) get this merged in?

tw15egan
tw15egan approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@tay1orjones
Copy link
Member

@tw15egan Thank you! and ah I forgot we had those TODO's in here 🤦‍♂️ Thoughts on merging as is? We could follow up with more comprehensive proptypes to address the TODOs later?

@tw15egan
Copy link
Member

tw15egan commented Jan 11, 2024 •
edited

@tay1orjones I'm fine merging this as-is and addressing those items separately, this PR seems to be blocking a few others

@tay1orjones tay1orjones added this pull request to the merge queue Jan 11, 2024
Merged via the queue into carbon-design-system:main with commit 8b4ba09 Jan 11, 2024
21 checks passed
@guidari guidari mentioned this pull request Jan 16, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tay1orjones tay1orjones tay1orjones approved these changes

@tw15egan tw15egan tw15egan approved these changes

@andreancardona andreancardona Awaiting requested review from andreancardona andreancardona is a code owner automatically assigned from carbon-design-system/developers-system

Assignees

@tay1orjones tay1orjones

Labels
status: ready to merge 🎉
Projects
Design System
Archived in project
Milestone
2024 Q1
4 participants
@k-rajat19 @tay1orjones @jdharvey-ibm @tw15egan