feat: add types to CodeSnippet and CodeSnippetSkeleton #15324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tay1orjones
approved these changes
Apr 8, 2024
tw15egan
approved these changes
Apr 8, 2024
Merged
via the queue into
carbon-design-system:main
with commit Apr 8, 2024
c0a358a
20 checks passed
preetibansalui
pushed a commit
to tay1orjones/carbon
that referenced
this pull request
Apr 24, 2024
…-system#15324) * feat: add types for CodeSnippet and CodeSnippetSkeleton * feat: add types to Copy and CopyButton * refactor: update index files to ts * fix: fix lint * revert: do not include changes for Copy and CopyButton --------- Co-authored-by: TJ Egan <tw15egan@gmail.com> Co-authored-by: Andrea N. Cardona <cardona.n.andrea@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13549
Add TypeScript types for CodeSnippet and CodeSnippetSkeleton
Depends on #15213
Changelog
New
Changed
Removed
Testing / Reviewing
Verify that unit tests run
Verify that components run in storybook