feat(treeview): add experimental controllable API #15397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@tay1orjones @emyarod Let me know if you have any questions around this! |
tay1orjones
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
Hey this looks really solid! Sorry it took so long for a review 😓
I think the feature flag name is good - so far the loose (undocumented) thinking I have on it is v12-* flags are committed to be turned on by default in the next major. We could always rename this flag if/when we think that's the case, but in the meantime I think naming it as is feels appropriate.
alisonjoseph
approved these changes
Feb 13, 2024
|
This LGTM! @emyarod do you have a chance to give this a review before we merge? |
tay1orjones
added
status: ready to merge 🎉
and removed
status: ready for review 👀
status: one more review 👀
labels
Merged
via the queue into
carbon-design-system:main
with commit Feb 26, 2024
b6710e7
21 checks passed
mHuzefa
pushed a commit
to mHuzefa/carbon
that referenced
this pull request
Feb 27, 2024
…em#15397) Co-authored-by: Andrea N. Cardona <cardona.n.andrea@gmail.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #14451 / Point 1
This PR introduces an experimental controllable API for the TreeView to address point 1 mentioned in above linked discussion.
A user must opt-in via the feature flag
enable-treeview-controllable.Changelog
New
enable-treeview-controllableprops.onActivateto pass-through node'sonToggleeventsprops.defaultIsExpandedfor uncontrolled modeChanged
selectedandactivecan be controlled or uncontrolled based on the user's choiceTesting / Reviewing
@tay1orjones I wanted to implement the feature flag approach you shared a while back for this change. Is there any naming guidance for these yet? I avoided
v12directly and essentially followed this structure:Let me know what you think!