Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(TileGroup): add TypeScript types #15430

Merged
merged 4 commits into from Jan 3, 2024

Conversation

Sam-Wool
Copy link
Contributor

Closes #13580

Changelog

Adds TypeScript typings to the TileGroup component

Testing / Reviewing

Accepts expected props, associated tests in yarn test pass, and functions normally in the react storybook

@Sam-Wool Sam-Wool requested a review from a team as a code owner December 19, 2023 22:46
Copy link
Contributor

github-actions bot commented Dec 19, 2023

DCO Assistant Lite bot All contributors have signed the DCO.

@Sam-Wool
Copy link
Contributor Author

I have read the DCO document and I hereby sign the DCO.

Copy link

netlify bot commented Dec 19, 2023

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 22fe109
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/659433558e0da10008ccc921
😎 Deploy Preview https://deploy-preview-15430--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀
Thanks for your contribution!

@github-actions github-actions bot added this pull request to the merge queue Jan 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 2, 2024
@guidari guidari added this pull request to the merge queue Jan 3, 2024
Merged via the queue into carbon-design-system:main with commit 7b93ccd Jan 3, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add TypeScript types to TileGroup
3 participants