Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Datepicker closeOnSelect prop #15431

Conversation

AdityaPimpalkar
Copy link
Contributor

Closes #15215

Datepicker should avoid the close action when the user select a date in the calendar if the closeOnSelect prop is set as false.

Changelog

New

  • Test case to check the intended behaviour when the prop is set to the desired condition

Changed

None

Removed

None

Copy link
Contributor

github-actions bot commented Dec 19, 2023

DCO Assistant Lite bot All contributors have signed the DCO.

@AdityaPimpalkar
Copy link
Contributor Author

I have read the DCO document and I hereby sign the DCO.

Copy link

netlify bot commented Dec 19, 2023

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 73f400e
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/65822ac2bd3dd90008baa49c
😎 Deploy Preview https://deploy-preview-15431--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀
Thanks for adding the tests also!

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tay1orjones tay1orjones added this pull request to the merge queue Jan 11, 2024
Merged via the queue into carbon-design-system:main with commit 58c87ff Jan 11, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Datepicker closeOnSelect prop is not working
3 participants