Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow aria-controls optional in TableExpand(Header|Row) types #15518

Merged
merged 1 commit into from Jan 11, 2024
Merged

fix: allow aria-controls optional in TableExpand(Header|Row) types #15518

merged 1 commit into from Jan 11, 2024

Conversation

dbrugger
Copy link
Contributor

@dbrugger dbrugger commented Jan 10, 2024 •
edited

aria-controls is expected to be optional in TableExpandHeader and TableExpandRow. Reference https://ibm-security.slack.com/archives/C03C8VASVED/p1704886339356979?thread_ts=1704880429.593959&cid=C03C8VASVED

Changelog

Changed

  • Make aria-controls option in TableExpandHeader and TableExpandRow types

Removed

  • Unnecessary ts-ignore clean-up

Testing / Reviewing

This is aligned with prop-type requirements

@dbrugger dbrugger requested a review from a team as a code owner January 10, 2024 12:15
@netlify Netlify
Copy link

netlify bot commented Jan 10, 2024

✅ Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8f758ed
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/659e8a71c10fa50008ade10c
😎 Deploy Preview https://deploy-preview-15518--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

tay1orjones
tay1orjones approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this! Someone was asking about it the other day in one of the slack channels.

@github-actions github-actions bot added this pull request to the merge queue Jan 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 11, 2024
@tay1orjones tay1orjones added this pull request to the merge queue Jan 11, 2024
Merged via the queue into carbon-design-system:main with commit 58eda4f Jan 11, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tay1orjones tay1orjones tay1orjones approved these changes

@tw15egan tw15egan tw15egan approved these changes

@alisonjoseph alisonjoseph Awaiting requested review from alisonjoseph alisonjoseph is a code owner automatically assigned from carbon-design-system/developers-system

@guidari guidari Awaiting requested review from guidari guidari is a code owner automatically assigned from carbon-design-system/developers-system

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dbrugger @tay1orjones @tw15egan