Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Modal): secondaryButtons prop type mismatch #15519

Merged
merged 1 commit into from Jan 16, 2024
Merged

fix(Modal): secondaryButtons prop type mismatch #15519

merged 1 commit into from Jan 16, 2024

Conversation

htndev
Copy link
Contributor

@htndev htndev commented Jan 10, 2024

Closes #15392

The issue has a type mismatch. The Modal component has a secondaryButtons that accepts the string type but also differs from the existing implementation.

Changelog

Changed

  • Fixed type mismatch

Testing / Reviewing

Check whether it accepts not only strings.

@htndev htndev requested a review from a team as a code owner January 10, 2024 12:20
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 10, 2024 •
edited

DCO Assistant Lite bot All contributors have signed the DCO.

@htndev
Copy link
Contributor Author

htndev commented Jan 10, 2024

I have read the DCO document and I hereby sign the DCO.

@netlify Netlify
Copy link

netlify bot commented Jan 10, 2024

✅ Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 832c31c
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/659e8ba8bf3e5500087ac0c3
😎 Deploy Preview https://deploy-preview-15519--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@htndev htndev mentioned this pull request Jan 10, 2024
Closed
1 task
@htndev htndev changed the title fix(Modal): modal secondary prop type fix(Modal): secondaryButtons prop type mismatch Jan 10, 2024
tay1orjones
tay1orjones approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

andreancardona
andreancardona approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@andreancardona andreancardona left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Thank you!

@github-actions github-actions bot added this pull request to the merge queue Jan 16, 2024
@tay1orjones tay1orjones removed this pull request from the merge queue due to a manual request Jan 16, 2024
@tay1orjones tay1orjones added this pull request to the merge queue Jan 16, 2024
Merged via the queue into carbon-design-system:main with commit e74c2b2 Jan 16, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tay1orjones tay1orjones tay1orjones approved these changes

@andreancardona andreancardona andreancardona approved these changes

@tw15egan tw15egan Awaiting requested review from tw15egan tw15egan was automatically assigned from carbon-design-system/developers-system

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Question]: Type mismatch in secondaryButtons prop in Modal component
3 participants
@htndev @tay1orjones @andreancardona