fix(icon-helpers): fix TypeScript type issues #15542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
andreancardona
approved these changes
Jan 24, 2024
andreancardona
added
status: ready to merge 🎉
and removed
status: one more review 👀
labels
Merged
via the queue into
carbon-design-system:main
with commit Jan 24, 2024
6a49fff
22 of 23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15114
Fixes TypeScript issues introduced when migrating getAttributes() function to TypeScript.
Changelog
Changed
Testing / Reviewing
Standard build/test runs must be passing. There should be no functional/behavioral changes introduced by this change. Using @carbon/icon-helpers in non-React projects should not cause any errors.