-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accordion controlled #15589
Accordion controlled #15589
Conversation
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks for the solid testing story. Everything looks good to me. We should do a patch release for this I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once test story is removed 👍 ✅
717495e
Closes #15347
The functionality that enable the user to control the
AccordionItem
open state was removed at some point. We added back.Stackblitz carbon v1.47.0 not working: https://stackblitz.com/edit/github-zc3uap-bqv7pp?file=src%2FApp.jsx,package.json
Stackblitz v10 working: https://stackblitz.com/edit/github-7wslrv?file=src%2FApp.jsx
Testing / Reviewing
Go the test story and check if it is working as expected.
Removed test story