Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accordion controlled #15589

Merged
merged 6 commits into from
Jan 24, 2024
Merged

Conversation

guidari
Copy link
Contributor

@guidari guidari commented Jan 23, 2024

Closes #15347

The functionality that enable the user to control the AccordionItem open state was removed at some point. We added back.

Stackblitz carbon v1.47.0 not working: https://stackblitz.com/edit/github-zc3uap-bqv7pp?file=src%2FApp.jsx,package.json
Stackblitz v10 working: https://stackblitz.com/edit/github-7wslrv?file=src%2FApp.jsx

Testing / Reviewing

  • Go the test story and check if it is working as expected.

  • Removed test story

@guidari guidari changed the title fix: added controlled state back Accordion controlled Jan 23, 2024
Copy link

netlify bot commented Jan 23, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 4e6a567
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/65b0fed636dfe600086a5cf7
😎 Deploy Preview https://deploy-preview-15589--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@guidari guidari marked this pull request as ready for review January 23, 2024 15:52
@guidari guidari requested a review from a team as a code owner January 23, 2024 15:52
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for the solid testing story. Everything looks good to me. We should do a patch release for this I think

Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once test story is removed 👍 ✅

@guidari guidari added this pull request to the merge queue Jan 24, 2024
Merged via the queue into carbon-design-system:main with commit 717495e Jan 24, 2024
20 checks passed
@guidari guidari deleted the 15347-accordion branch January 24, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: open prop is ignored on AccordionItem
3 participants