fix(Slug): adjust callout width, fix revert story #15591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
andreancardona
approved these changes
Jan 23, 2024
|
One small thing I'm seeing is that when the disabled prop is set to true - there is a conflicting red / blue border in the bottom right hand corner of the input container. Let me know what you think! |
andreancardona
requested changes
Jan 23, 2024
|
Oh, nice catch, @andreancardona! Fixed, it should be good now. |
andreancardona
approved these changes
Jan 23, 2024
andreancardona
added
status: one more review 👀
and removed
status: ready for review 👀
labels
Merged
via the queue into
carbon-design-system:main
with commit Jan 25, 2024
19b48f3
21 checks passed
This was referenced Jan 29, 2024
kodiakhq bot
pushed a commit
to carbon-design-system/carbon-for-ibm-dotcom
that referenced
this pull request
Feb 2, 2024
### Related Ticket(s) Follows: carbon-design-system/carbon#15596 & carbon-design-system/carbon#15591 ### Description Updates Tile with carbon gradient ### Changelog **Changed** - new carbon upgrade (using RC atm -> will need to update to full release) - updated tile slug styles like core - the new core styles fix an error with number-input slug revert styles <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some issues that @aagonzales pointed out with the latest
AIupdatesChangelog
Changed
max-widthfor all callouts (action vs without action)NumberInputis removed when the ai styles are not active (revert test story)Testing / Reviewing
Ensure padding is correct for the action bar variant of the callout. Ensure the
NumberInputborder is removed when a user changes the ai value (Slug --> Form --> Revert Test)