Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(global-theme): clarify that styles won't be applied automatically #15609

Merged
merged 2 commits into from Feb 13, 2024

Conversation

janhassel
Copy link
Member

Expands the documentation around GlobalTheme to avoid confusion over why no css custom properties are emitted when changing its theme prop.

@janhassel janhassel requested a review from a team as a code owner January 26, 2024 08:00
Copy link

netlify bot commented Jan 26, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit cac00c6
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/65b36cda36674600083ff416
😎 Deploy Preview https://deploy-preview-15609--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating these docs! 🙌

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much, this is a great addition. We've had questions about this before and didn't have anywhere to point folks.

@tay1orjones tay1orjones added this pull request to the merge queue Feb 13, 2024
Merged via the queue into carbon-design-system:main with commit 6d32885 Feb 13, 2024
22 checks passed
@janhassel janhassel deleted the globaltheme-docs branch February 14, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants