Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ChatButton): add in ChatButton component #15675

Merged
merged 12 commits into from Feb 7, 2024

Conversation

tw15egan
Copy link
Member

@tw15egan tw15egan commented Feb 1, 2024

Closes #15621

Adds in the ChatButton component, which is just a wrapper around Button that restricts the component adhere to AI styles

Screenshot 2024-02-07 at 10 30 53 AM

Changelog

New

  • New unstable__ChatButton and unstable__ChatButtonSkeleton components
  • AVT and VRT tests for ChatButton

Testing / Reviewing

Ensure the new component matches the spec

Copy link

netlify bot commented Feb 1, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 9e54db0
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/65c28be04cc37f0009cc367b
😎 Deploy Preview https://deploy-preview-15675--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tw15egan tw15egan requested a review from a team as a code owner February 2, 2024 16:47
@aagonzales
Copy link
Member

Visually, this looks good! I just want to confirm we've got the interaction of the new state correct. Now that I see it, I'm wondering if it should actually be more of a read-only instead of disabled.

Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the chat devs are good with this, then I think its good to go 👍

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@guidari guidari added this pull request to the merge queue Feb 7, 2024
Merged via the queue into carbon-design-system:main with commit 0eac7a8 Feb 7, 2024
21 checks passed
@carbon-automation
Copy link
Contributor

Hey there! v11.50.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add AI enhancements to React Button enhancements
4 participants