New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(datepicker): added waitFor() to react.lazy test #15702
fix(datepicker): added waitFor() to react.lazy test #15702
Conversation
fixes: #15701 |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hey thanks for opening this, could you outline how this helps the test? The RTL docs state that I think this change will cause a warning to pop during the the lint ci check - carbon/config/eslint-config-carbon/plugins/testing-library.js Lines 14 to 21 in 0ee6ff9
This preset enables the |
d86c8d5
to
e27d395
Compare
Yes, you're right. What I added wasn't quite right. I've updated this to add the timeout directly to the call to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks!
7719b73
Closes #15701
{{short description}}
Changelog
New
Changed
Removed
Testing / Reviewing
{{ Add descriptions, steps or a checklist for how reviewers can verify this PR works or not }}