refactor(Modal): use mask-image for overflow indicator #15734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tw15egan
added
status: ready for review 👀
status: visual review 🔍
and removed
status: visual review 🔍
labels
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
guidari
approved these changes
Feb 13, 2024
Merged
via the queue into
carbon-design-system:main
with commit Feb 13, 2024
ffc385b
21 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #15727
While working on #15727 I used
mask-imageto fade out the overflow content insideModalwhenhasScrollingContentis set to true. This PR refactorsModalandComposedModalto use this property instead of pseudoelements to achieve the effect.We could also use this to refactor
CodeSnippet, but we would need to change the dimensions for RTL since the gradient directions do not use logical propertiesChangelog
New
mask-imageto.cds--modal-scroll-content. The extra dimensions prevent the mask from overlaying the focus outline + scroll bar.Removed
cds--modal-content--overflow-indicatorand all associated stylesTesting / Reviewing
Ensure there are no style regressions on the
ModalandComposedModalwith scrolling content.