Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(notification): clean up static notification stories #15767

Conversation

tay1orjones
Copy link
Member

I noticed during demo today that these stories could use a clean up.

Changelog

Changed

  • Improves StaticNotification stories to show a proper use of an inline link, including the required aria-describedby, and opting to use a div with a manually applied subtitle class instead of using the subtitle prop (which only allows a string)
  • Updated documentation to more clearly state the impact of rendering this component after the initial render of the page as it relates to screenreader user focus and the DOM.

Removed

  • unecessary testing stories that were focused on the aria-describedby warnings

Testing / Reviewing

  • Ensure StaticNotification stories work and the docs make sense

Copy link

netlify bot commented Feb 15, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 8a22ec7
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/65ce629d8f7e100008a2c802
😎 Deploy Preview https://deploy-preview-15767--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 15, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit fa37557
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/65ce636413be0200083220e8
😎 Deploy Preview https://deploy-preview-15767--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@guidari guidari added this pull request to the merge queue Feb 19, 2024
Merged via the queue into carbon-design-system:main with commit b438ffd Feb 19, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants