Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: inline dropdown has border bottom in readonly variant #15773

Merged
merged 2 commits into from Feb 19, 2024
Merged

fix: inline dropdown has border bottom in readonly variant #15773

merged 2 commits into from Feb 19, 2024

Conversation

preetibansalui
Copy link
Contributor

@preetibansalui preetibansalui commented Feb 16, 2024 •
edited

Closes #15367

fixed - inline dropdown has border bottom in readonly variant

Testing / Reviewing

  1. Go to Dropdown
  2. Change its type as 'inline'
  3. Change 'readonly' as true
  4. It should not show a border bottom

@preetibansalui preetibansalui requested a review from a team as a code owner February 16, 2024 15:56
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 16, 2024 •
edited

DCO Assistant Lite bot All contributors have signed the DCO.

@preetibansalui
Copy link
Contributor Author

I have read the DCO document and I hereby sign the DCO.

@netlify Netlify
Copy link

netlify bot commented Feb 16, 2024 •
edited

✅ Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 38d3915
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/65cf8be2f61d830008234c37
😎 Deploy Preview https://deploy-preview-15773--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

tw15egan
tw15egan approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅ 🎉

@carbon-bot carbon-bot added this pull request to the merge queue Feb 19, 2024
Merged via the queue into carbon-design-system:main with commit f12e27b Feb 19, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tay1orjones tay1orjones tay1orjones approved these changes

@tw15egan tw15egan tw15egan approved these changes

@alisonjoseph alisonjoseph Awaiting requested review from alisonjoseph alisonjoseph is a code owner automatically assigned from carbon-design-system/developers-system

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Inline dropdown has bottom border in readOnly variant
4 participants
@preetibansalui @tay1orjones @tw15egan @carbon-bot