Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(radiotile): update to use radio button icon #15786

Merged
merged 9 commits into from Mar 1, 2024

Conversation

2nikhiltom
Copy link
Contributor

@2nikhiltom 2nikhiltom commented Feb 20, 2024

Closes #15478

Changelog

New

  • Radio tile and Radio with layer are updated to use radio buttons icons instead of checkmarks
  • Should keep radio unchecked if no defaultSelected is provided
  • Adds new feature flag "enable-v12-tile-radio-icons"

Changed

  • Icons are changed : checkmarks -> radio icons
  • Adds new test to verify unselected/unchecked radio if no defaultSelected is provided

Old checkmark icons on : Radio tile and Radio with layer
Old-checkmarks

New radio icons on : Radio tile and Radio with layer
New-radioIcons

Testing / Reviewing

Perform the below for Radio-tiles and Radio-with-layers stories

  • Verify that radio icons are rendered
  • Verify that the radio is not selected/checked if no defaultSelected is provided

Copy link

netlify bot commented Feb 20, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f8d7bee
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/65e220ee250fe60008a5db62
😎 Deploy Preview https://deploy-preview-15786--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@2nikhiltom 2nikhiltom marked this pull request as ready for review February 21, 2024 18:00
@2nikhiltom 2nikhiltom requested a review from a team as a code owner February 21, 2024 18:00
@2nikhiltom 2nikhiltom marked this pull request as draft February 21, 2024 18:04
@2nikhiltom 2nikhiltom assigned 2nikhiltom and unassigned 2nikhiltom Feb 21, 2024
@2nikhiltom 2nikhiltom marked this pull request as ready for review February 22, 2024 08:36
@tay1orjones
Copy link
Member

@2nikhiltom looks like there's a minor conflict here that needs resolved

@2nikhiltom
Copy link
Contributor Author

Merged 'main' to 'tiles_radio_icons'

Copy link

@Kritvi-bhatia17 Kritvi-bhatia17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @2nikhiltom!
Looks good to me 🔥

Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@2nikhiltom 2nikhiltom added this pull request to the merge queue Mar 1, 2024
Merged via the queue into carbon-design-system:main with commit ef9501b Mar 1, 2024
20 checks passed
@2nikhiltom 2nikhiltom deleted the tiles_radio_icons branch March 1, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Selectable Components: Tile] Dev Implementation
6 participants