fix: set correct visited link tokens for link and toggletip #15790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisonjoseph
requested review from
tw15egan,
guidari,
a team and
aubrey-oneal
and removed request for
a team
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tw15egan
approved these changes
Feb 23, 2024
laurenmrice
approved these changes
Feb 29, 2024
Merged
via the queue into
carbon-design-system:main
with commit Mar 11, 2024
2e53484
20 checks passed
|
Hey there! v11.53.0 was just released that references this issue/PR. |
preetibansalui
pushed a commit
to tay1orjones/carbon
that referenced
this pull request
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13400
Visited link styles were displaying incorrectly inside of ToggleTip
Until #15204 is resolved (adding
$link-inverse-hoverand$link-inverse-visitedtokens) all states for links inside ofToggleTipwill be displayed as$link-inverseso will at least be accessible, where before they were not.Changelog
New
link-visited-text-colorin toggletip scssChanged
ToggleTipdisplay correctly.Testing / Reviewing
Check that link colors are correct for
LinkandToggleTipcomponents