Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(Slug): add API, keyboard tests for Slug #15792

Merged
merged 5 commits into from Feb 26, 2024

Conversation

tw15egan
Copy link
Member

@tw15egan tw15egan commented Feb 20, 2024

Closes #15273

Adds in tests for the Slug component, as well as adding tests for components with a slug prop

Changelog

New

  • Keyboard interaction tests for Slug
  • API tests for Slug
  • API tests for components that have a slug prop

Changed

  • Toggletip now passes ...rest props into Popover
  • changed instances of cds to ${prefix} in component API tests

Testing / Reviewing

Ensure all tests pass and cover intended use cases

Copy link

netlify bot commented Feb 20, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 21a962a
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/65d614614609a100087ec8d3
😎 Deploy Preview https://deploy-preview-15792--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tw15egan tw15egan changed the title Add slug tests test(Slug): add API, keyboard tests for Slug Feb 21, 2024
@tw15egan tw15egan marked this pull request as ready for review February 21, 2024 15:18
@tw15egan tw15egan requested a review from a team as a code owner February 21, 2024 15:18
Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@guidari guidari added this pull request to the merge queue Feb 26, 2024
Merged via the queue into carbon-design-system:main with commit ee60555 Feb 26, 2024
23 checks passed
mHuzefa pushed a commit to mHuzefa/carbon that referenced this pull request Feb 27, 2024
…15792)

* test(Slug): add keyboard tests

* test(Slug): add api tests

* test(Slug): add slug tests to existing components

* test(Slug): add tests for remaining slug components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add basic tests for slug prop on components
3 participants