fix(CodeSnippet): adjust calculation when show more button is clicked #15839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Maybe I'm missing what this is trying to fix, but I think the show more button shouldn't be showing at all in the test story since the code block fits entirely in the window. I'm seeing the same issue in windows and mac. |
|
@alisonjoseph I tweaked some things so it should now appropriately show / hide the button as well |
Merged
via the queue into
carbon-design-system:main
with commit Mar 7, 2024
cd5ac20
20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15774
Based on this comment, I've adjusted the default
minExpandedNumberOfRowsto0.Changelog
Changed
minExpandedNumberOfRowsto0Testing / Reviewing
View the test story in
CodeSnippeton a Windows machine and ensure there are no visual bugs.