New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(AISkeleton): update token values #15840
fix(AISkeleton): update token values #15840
Conversation
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Something isn't right here (design messed up not dev). Just looked at the example is its barely notificable. I just dropped in the updated values Juan gave me with out looking at them but it might actually need some adjusting in code vs figma. Let me take a quick look at things and get back to you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok can we update the element values by two steps. Right now you can't see the dark animation at all.
Token | White theme | Gray 10 theme | Gray 90 theme | Gray 100 theme |
---|---|---|---|---|
AI-skeleton-element | Blue 50 | Blue 50 | Blue 60 | Blue 60 |
@aagonzales updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Light theme looks good now but the dark is still too faded. For Gray 90 and Gray 100, let's take the element up to 'Blue 80'. I think that should do it.
8da1b0a
to
5078c0e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I think that's good now. Geez what a problem child the dark theme was here.
5f122a7
Closes #15825
Changelog
Changed
AI Skeleton
token valuesTesting / Reviewing
Ensure the animation looks correct