Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AISkeleton): update token values #15840

Merged
merged 4 commits into from Mar 7, 2024

Conversation

tw15egan
Copy link
Member

Closes #15825

Changelog

Changed

  • Updates the AI Skeleton token values

Testing / Reviewing

Ensure the animation looks correct

@tw15egan tw15egan requested a review from a team as a code owner February 28, 2024 16:33
Copy link

netlify bot commented Feb 28, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 5078c0e
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/65e8dd4d3dcd230008a3d401
😎 Deploy Preview https://deploy-preview-15840--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@aagonzales
Copy link
Member

aagonzales commented Mar 4, 2024

Something isn't right here (design messed up not dev). Just looked at the example is its barely notificable. I just dropped in the updated values Juan gave me with out looking at them but it might actually need some adjusting in code vs figma. Let me take a quick look at things and get back to you.

Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok can we update the element values by two steps. Right now you can't see the dark animation at all.

Token White theme Gray 10 theme Gray 90 theme Gray 100 theme
AI-skeleton-element Blue 50 Blue 50 Blue 60 Blue 60

@tw15egan
Copy link
Member Author

tw15egan commented Mar 6, 2024

@aagonzales updated

Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Light theme looks good now but the dark is still too faded. For Gray 90 and Gray 100, let's take the element up to 'Blue 80'. I think that should do it.

Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I think that's good now. Geez what a problem child the dark theme was here.

@tw15egan tw15egan added this pull request to the merge queue Mar 7, 2024
Merged via the queue into carbon-design-system:main with commit 5f122a7 Mar 7, 2024
20 checks passed
@tw15egan tw15egan deleted the ai-skeleton-update branch March 7, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AI Skeleton: update token values
4 participants