Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: active states and focus states of inline and standalone links #15846

Conversation

riddhybansal
Copy link
Contributor

Closes #15613

Added an underline on the focus state and active state

Changed

  • Changed some styles to incorporate underline at different states

Testing / Reviewing

  • Test the default and inline link component in active and focus states it should have underline.

Copy link

netlify bot commented Feb 29, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 03e05af
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/65e0ab33efa6d400086f0cf7
😎 Deploy Preview https://deploy-preview-15846--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great Riddhi! Just one thing:

Focus state
In Firefox and Safari I can not get the Focus state on the actual Link in the example/demo on any of the stories. I could get it in Chrome, and it looks good! Just was wondering if that is a bug or if you have to operate things differently in those browsers to get the Focus on the link.

@guidari
Copy link
Contributor

guidari commented Mar 1, 2024

Seems like it is a problem on Safari and FF.
I used this solution here from StackOverflow and worked in FF, but not for Safari

Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got it working on Safari.
Go to Safari Settings -> Advanced
Enable the option: Press Tab to highlight each item on a webpage page

Screenshot 2024-03-01 at 13 36 53

I'll approve, since it is something from the browsers

@riddhybansal
Copy link
Contributor Author

@laurenmrice Its working on Safari as well , some settings needs to be changed.

@riddhybansal riddhybansal added this pull request to the merge queue Mar 1, 2024
Merged via the queue into carbon-design-system:main with commit 17b30f7 Mar 1, 2024
20 checks passed
@riddhybansal riddhybansal deleted the Adding_an_underline_on_the_focus_state_and_active_state branch March 1, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Link] Adding an underline on the focus state and active state
4 participants