feat(datepicker): add parseDate prop, improve default date parsing
#15918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tay1orjones
changed the title
parseDate prop, improve default date parsing
Closed
2 tasks
andreancardona
approved these changes
Mar 13, 2024
andreancardona
added
status: ready to merge 🎉
and removed
status: ready for review 👀
labels
Merged
via the queue into
carbon-design-system:main
with commit Mar 13, 2024
4890639
20 checks passed
preetibansalui
pushed a commit
to tay1orjones/carbon
that referenced
this pull request
Apr 24, 2024
…arbon-design-system#15918) * feat(datepicker): improve date parsing for default format, add parseDate as prop * chore(datepicker): fix typescript warnings * fix(datepicker): improve parseDate logic and comments * test(datepicker): cover parseDate functionality * test(datepicker): cover totally invalid date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15432
Part of #13828
This improves DatePicker's date parsing functionality when using the default
dateFormat. It also adds a newparseDateprop for consumers to supply their own date parsing function when using other date formats.How this works:
1will be used instead.a1/0a/a999), the input will be cleared.dateFormatis used and aparseDateis not provided, the default within flatpickr will be used, which can cause odd date correction based on how native date methods work, [Bug]: DatePicker input seems to convert date if not given in the correct date format #15432 (comment)Changelog
New
parseDateprop to DatePickerparseDateprop function, and completely invalid dates.Testing / Reviewing
01and totally invalid dates should clear the input.