fix(ComposedModal): align handleMouseDown between Modal, ComposedModal #15934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alisonjoseph
approved these changes
Apr 4, 2024
guidari
approved these changes
Apr 8, 2024
Merged
via the queue into
carbon-design-system:main
with commit Apr 10, 2024
ad1362c
20 checks passed
|
Hey there! v11.55.0 was just released that references this issue/PR. |
preetibansalui
pushed a commit
to tay1orjones/carbon
that referenced
this pull request
Apr 24, 2024
carbon-design-system#15934) * fix(ComposedModal): align handleMouseDown between Modal, ComposedModal * test(ComposedModal): update snaps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15857
Fixes an issue preventing
selectorsFloatingMenusfrom being used to prevent modal closures. Now aligned withModalusage, and only runs ifpreventCloseOnClickOutsideis set to false.Changelog
Changed
handleMouseDownusage betweenModalandComposedModalTesting / Reviewing
Ensure there are no regressions to
ComposedModaland that portals do not close theComposedModalif they are passed in toselectorsFloatingMenus