Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(combobox): invalid and warn text should be read by screenreaders #15954

Conversation

tay1orjones
Copy link
Member

@tay1orjones tay1orjones commented Mar 13, 2024

Closes #10050

This is sort-of a continuation of #13371, where aria-describedby was added, but only for the helperText. This adds support for warnText and invalidText being read as noted in #12722

... any caution or warning text appearing in the helper text area will [should] also be announced

Changelog

New

  • Added two new props to ListBox so we can supply and id for the warn text node and the invalid text node

Changed

  • Updated the Combobox input to have aria-describedby have a value pointing to the helperText, warnText, or invalidText, when appropriate

Testing / Reviewing

  • Take Combobox for a spin in JAWS - when Combobox is given invalid and invalidText, the screenreader should read the invalidText when the input is focused.
  • Do the same thing with voiceover

Copy link

netlify bot commented Mar 14, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 377d1d6
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/65f2f2f11ecfe30008097699
😎 Deploy Preview https://deploy-preview-15954--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 14, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit cff71c6
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/65f2f2fd8ee075000800efb0
😎 Deploy Preview https://deploy-preview-15954--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM! 🚀

Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed! 😎

@tw15egan tw15egan added this pull request to the merge queue Mar 20, 2024
Merged via the queue into carbon-design-system:main with commit 80c75e2 Mar 20, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[a11y]: ComboBox validation error is not read out by JAWS
4 participants