Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed style in inline notification #15973

Merged
merged 2 commits into from Mar 26, 2024

Conversation

guidari
Copy link
Contributor

@guidari guidari commented Mar 14, 2024

Closes #15958

Changed the "!" to the dark color when lowContrast is true.

Testing / Reviewing

  • Check for Percy changes
  • Go to Actionable Notification Playground and change these props:
    • Inline = true
    • kind = warning
    • lowContrast = true

@guidari guidari requested a review from a team as a code owner March 14, 2024 20:23
Copy link

netlify bot commented Mar 14, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 86c4e66
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/65f35cd93df8320008ff4c18
😎 Deploy Preview https://deploy-preview-15973--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 14, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 947fd6c
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/65f35d4a7069160008978951
😎 Deploy Preview https://deploy-preview-15973--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@andreancardona
Copy link
Contributor

@thyhmdo tagging you for visual review :)

@andreancardona andreancardona added this pull request to the merge queue Mar 26, 2024
Merged via the queue into carbon-design-system:main with commit 6f55ab9 Mar 26, 2024
20 checks passed
@carbon-automation
Copy link
Contributor

Hey there! v11.54.0 was just released that references this issue/PR.

preetibansalui pushed a commit to tay1orjones/carbon that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Actionable Inline Notification and Inline Notification have different warning icon in lowContrast
4 participants