fix: content padding removed after inserting theme in headercontainer #15998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alisonjoseph
approved these changes
Mar 19, 2024
tw15egan
approved these changes
Mar 19, 2024
Merged
via the queue into
carbon-design-system:main
with commit Mar 19, 2024
4042f5f
20 checks passed
preetibansalui
added a commit
to tay1orjones/carbon
that referenced
this pull request
Apr 24, 2024
…carbon-design-system#15998) * fix: content padding removed after inserting theme in headercontainer * chore(yarn): run dedupe --------- Co-authored-by: TJ Egan <tw15egan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13450
Fixed - Content padding removed after inserting theme in header container
Testing / Reviewing
Add a HeaderContainer>Theme>Header and after Header container add some content. It should not remove the top margin from the content and content should be properly visible.