Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: TileGroup to accept wrappers around RadioTiles. #16001

Merged
merged 7 commits into from Mar 21, 2024
Merged

fix: TileGroup to accept wrappers around RadioTiles. #16001

merged 7 commits into from Mar 21, 2024

Conversation

Gururajj77
Copy link
Contributor

Closes #15884

Fixes the TileGroup to accept wrappers around RadioTiles when used under TileGroup

Changelog

New

  • Added displayName prop to RadioTile

Changed

  • reworked on getRadioTiles and renamed it to getRadioTilesWithWrappers

Testing / Reviewing

Please add wrappers around RadioTiles when using under TileGroup

@Gururajj77 Gururajj77 requested a review from a team as a code owner March 19, 2024 09:53
@netlify Netlify
Copy link

netlify bot commented Mar 19, 2024

✅ Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit aaa086f
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/65f960aa49efce0008b2b9ee
😎 Deploy Preview https://deploy-preview-16001--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Gururajj77 Gururajj77 changed the title Tilegroup wrapper Fix for TileGroup to accept wrappers around RadioTiles. Mar 19, 2024
@Gururajj77 Gururajj77 changed the title Fix for TileGroup to accept wrappers around RadioTiles. Fix: fix for TileGroup to accept wrappers around RadioTiles. Mar 19, 2024
@andreancardona andreancardona changed the title Fix: fix for TileGroup to accept wrappers around RadioTiles. fix: TileGroup to accept wrappers around RadioTiles. Mar 19, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 20, 2024 •
edited

✅ Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit dbca08f
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/65fca07f895f7e0008a2f2b0
😎 Deploy Preview https://deploy-preview-16001--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

alisonjoseph
alisonjoseph approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally with both divs and grid wrappers and this works as expected. 🙌

@Gururajj77 feel free in the future to create a test story (that can be removed before merge) for easier review/testing, especially on PRs that need a design review.

tw15egan
tw15egan approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@tw15egan tw15egan enabled auto-merge March 21, 2024 21:03
@tw15egan tw15egan added this pull request to the merge queue Mar 21, 2024
Merged via the queue into carbon-design-system:main with commit dccc214 Mar 21, 2024
20 checks passed
@Gururajj77
Copy link
Contributor Author

Tested locally with both divs and grid wrappers and this works as expected. 🙌

@Gururajj77 feel free in the future to create a test story (that can be removed before merge) for easier review/testing, especially on PRs that need a design review.

Sure, will do this from next.

@Gururajj77 Gururajj77 deleted the tilegroup-wrapper branch April 2, 2024 13:06
preetibansalui pushed a commit to tay1orjones/carbon that referenced this pull request Apr 24, 2024
@Gururajj77 @tay1orjones
@andreancardona @tw15egan @preetibansalui
fix: TileGroup to accept wrappers around RadioTiles. (carbon-design-s…
ad06ea9 
…ystem#16001)

* fix: fixes the default withOverlay prop

* fix: fixed the tilegroup to accept wrappers around the radiotile

* fix: removed comments

---------

Co-authored-by: Taylor Jones <tay1orjones@users.noreply.github.com>
Co-authored-by: Andrea N. Cardona <cardona.n.andrea@gmail.com>
Co-authored-by: TJ Egan <tw15egan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisonjoseph alisonjoseph alisonjoseph approved these changes

@tw15egan tw15egan tw15egan approved these changes

Assignees
No one assigned
Labels
status: one more review 👀 status: ready for review 👀
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Using Grid with RadioTile and TileGroup breaks the UI
5 participants
@Gururajj77 @alisonjoseph @tw15egan @tay1orjones @andreancardona