fix(Slug): updates Slug styles to match new floating-ui selectors #16039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alisonjoseph
approved these changes
Mar 25, 2024
|
@andreancardona just need a thumbs up here and it should be good to merge |
tw15egan
added
status: ready for review 👀
status: one more review 👀
and removed
status: ready to merge 🎉
labels
andreancardona
added
status: ready to merge 🎉
and removed
status: ready for review 👀
status: one more review 👀
labels
Merged
via the queue into
carbon-design-system:main
with commit Apr 3, 2024
c573f97
20 checks passed
preetibansalui
pushed a commit
to tay1orjones/carbon
that referenced
this pull request
Apr 24, 2024
…rbon-design-system#16039) * fix(Slug): updates Slug styles to match new floating-ui selectors * chore: update snapshot --------- Co-authored-by: Andrea N. Cardona <cardona.n.andrea@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15935
Updates
Slugso that only the new (for the most part) controls show up instorybook, and aligns the styles so that they display properly. I don't think there is a way to throw deprecate warnings for some items insidePropTypes.oneOf, if there is let me know 👍Changelog
New
floating-uilogical propertiesRemoved
.#{$prefix}--slug--enabledwhich was eliminated with the removal of the filled-in slug in feat(Slug): implement phase 3 updates, adjust token values #15943Testing / Reviewing
Ensure all
alignorientations work in theunstable__slug --> calloutstory